Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix RichTextElement.elements items are never promoted to a proper Python object type #1492

Merged
merged 4 commits into from
May 3, 2024

Conversation

k1e1n04
Copy link
Contributor

@k1e1n04 k1e1n04 commented May 2, 2024

Summary

This pull request resolves #1468

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented web-client Version: 3x labels May 3, 2024
@seratch seratch added this to the 3.27.2 milestone May 3, 2024
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code formatting for the test code is missing. Could you fix it?

@k1e1n04 k1e1n04 requested a review from seratch May 3, 2024 03:37
@k1e1n04
Copy link
Contributor Author

k1e1n04 commented May 3, 2024

I have made the necessary corrections. Could you please check and confirm if everything is in order?

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.24%. Comparing base (059dd68) to head (58c92d3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1492      +/-   ##
==========================================
+ Coverage   85.20%   85.24%   +0.04%     
==========================================
  Files         111      111              
  Lines       12291    12291              
==========================================
+ Hits        10472    10477       +5     
+ Misses       1819     1814       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you; LGTM

@seratch seratch merged commit 694ec2f into slackapi:main May 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented cla:signed Version: 3x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RichTextElement.elements items are never promoted to a proper Python object type
2 participants