Adding new admin and remote files API methods. #501
Conversation
Codecov Report
@@ Coverage Diff @@
## master #501 +/- ##
==========================================
- Coverage 69.58% 68.86% -0.73%
==========================================
Files 15 15
Lines 1654 1686 +32
Branches 91 93 +2
==========================================
+ Hits 1151 1161 +10
- Misses 481 503 +22
Partials 22 22
Continue to review full report at Codecov.
|
slack/web/client.py
Outdated
| @@ -66,6 +66,33 @@ class WebClient(BaseClient): | |||
| removed at anytime. | |||
| """ | |||
|
|
|||
| def admin_apps_approve(self, **kwargs) -> Union[Future, SlackResponse]: | |||
| """Approve an app for installation on a workspace.""" | |||
There was a problem hiding this comment.
not sure how you'd like to handle this (if its a pattern that's happened on other methods), but this method requires either the app_id argument or the request_id argument. technically, they are both optional, but as you can see that's not the whole story.
for comparison, in node we don't have anything helpful to tell the developer about this right now (aside from a code comment). just wanted to flag that in case you could come up with something better for python developers.
There was a problem hiding this comment.
This is a great callout! Currently for other methods we manually add this validation. I'll be sure to update this for this method as well. Thank you!
Summary
Adds methods and types related to Slack's new Remote Files API. Learn more: https://api.slack.com/messaging/files/remote
Admins of enterprise grid organizations can also now use the Web API to approve, restrict, or list app installation requests. Learn more: https://api.slack.com/admins/managing
Requirements (place an
xin each[ ])