Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for value length in button elements #514

Merged
merged 2 commits into from Sep 25, 2019

Conversation

avanderm
Copy link
Contributor

Summary

Bugfix for max value length in button elements. Documentation indicates 2000, the code however permits no more than 75 characters.

Requirements

@CLAassistant
Copy link

CLAassistant commented Sep 17, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #514 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #514      +/-   ##
==========================================
+ Coverage   69.11%   69.23%   +0.11%     
==========================================
  Files          15       15              
  Lines        1690     1690              
  Branches       93       93              
==========================================
+ Hits         1168     1170       +2     
+ Misses        499      498       -1     
+ Partials       23       22       -1
Impacted Files Coverage Δ
slack/web/classes/elements.py 85.54% <100%> (ø) ⬆️
slack/rtm/client.py 84.23% <0%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112dd12...a5e1c83. Read the comment docs.

@RodneyU215
Copy link
Contributor

Thanks for this PR @avanderm! Great catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants