Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve a code snippet on README #516

Merged
merged 1 commit into from Sep 25, 2019
Merged

Conversation

seratch
Copy link
Member

@seratch seratch commented Sep 22, 2019

Summary

This pull request improves the RTM code snippet on README. Currently, the code fails every time a bot message is posted with KeyError as below:

(omitted)
  File "app.py", line 11, in say_hello
    if data and 'Hello' in data['text']:
KeyError: 'text'

Requirements (place an x in each [ ])

@RodneyU215 RodneyU215 merged commit dbe248d into slackapi:master Sep 25, 2019
@seratch seratch deleted the fix-readme branch September 25, 2019 01:02
@seratch
Copy link
Member Author

seratch commented Sep 25, 2019

Thanks for checking this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants