Adding View API's and fixing OAuth Headers Bug #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RodneyU215
added
Priority: High
bug
Codecov Report
@@ Coverage Diff @@
## master #517 +/- ##
==========================================
- Coverage 69.23% 68.89% -0.34%
==========================================
Files 15 15
Lines 1690 1707 +17
Branches 93 96 +3
==========================================
+ Hits 1170 1176 +6
- Misses 498 508 +10
- Partials 22 23 +1
Continue to review full report at Codecov.
|
shaydewael
approved these changes
Sep 25, 2019
shaydewael
approved these changes
Sep 25, 2019
Roach
reviewed
Sep 25, 2019
|
|
||
| See `views.update <https://api.slack.com/methods/views.update>`_ for more info. | ||
|
|
||
| If you want to push a new view onto the modal instead of updating an existing view, reference the `views.push <https://api.slack.com/methods/views.push>`_ documentation. |
There was a problem hiding this comment.
May be worth mentioning the 3 modal limit here
There was a problem hiding this comment.
We have a subsequent docs revamp that will be shipped as a fast follow. I'll be sure to update it there.
shaydewael
approved these changes
Sep 25, 2019
Roach
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds new View API's.
It also fixes a bug where the client credentials were not being passed through the headers.
Requirements (place an
xin each[ ])