Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip token string parameters of whitespace #599

Merged
merged 1 commit into from Feb 13, 2020

Conversation

TheFrozenFire
Copy link
Contributor

Summary

If tokens contain whitespace, API calls fail in a confusing manner. See #598.

This change simply strips whitespace from tokens, to avoid confusing failures.

Requirements (place an x in each [ ])

@claassistantio
Copy link

claassistantio commented Jan 20, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 20, 2020

Codecov Report

Merging #599 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #599   +/-   ##
=======================================
  Coverage   69.87%   69.87%           
=======================================
  Files          15       15           
  Lines        1726     1726           
  Branches       98       98           
=======================================
  Hits         1206     1206           
  Misses        493      493           
  Partials       27       27
Impacted Files Coverage Δ
slack/web/base_client.py 78.5% <100%> (ø) ⬆️
slack/rtm/client.py 83.15% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6252ff2...2531a40. Read the comment docs.

@stevengill stevengill added the enhancement M-T: A feature request for new functionality label Jan 29, 2020
@stevengill stevengill self-assigned this Jan 30, 2020
@stevengill stevengill merged commit 647f7ab into slackapi:master Feb 13, 2020
@seratch seratch added this to the 2.6.0 milestone Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants