Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin.usergroups.* API support #682

Merged
merged 1 commit into from May 14, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented May 12, 2020

Summary

This pull request adds the following admin APIs to this SDK.

  • admin.usergroups.addChannels
  • admin.usergroups.listChannels
  • admin.usergroups.removeChannels

Refer to https://api.slack.com/enterprise/managing#defaultchannels for details.

Requirements (place an x in each [ ])

@seratch seratch added Version: 2x enhancement M-T: A feature request for new functionality web-client labels May 12, 2020
@seratch seratch added this to the 2.6.0 milestone May 12, 2020
@seratch seratch self-assigned this May 12, 2020
* admin.usergroups.addChannels
* admin.usergroups.listChannels
* admin.usergroups.removeChannels

Refer to https://api.slack.com/enterprise/managing#defaultchannels
 for details.
@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #682 into master will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
+ Coverage   86.92%   87.02%   +0.10%     
==========================================
  Files          16       16              
  Lines        1889     1904      +15     
  Branches      126      128       +2     
==========================================
+ Hits         1642     1657      +15     
  Misses        210      210              
  Partials       37       37              
Impacted Files Coverage Δ
slack/web/client.py 96.69% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c755a9...4950a01. Read the comment docs.

@seratch seratch merged commit 5a44b09 into slackapi:master May 14, 2020
@seratch seratch deleted the admin-usergroups branch May 14, 2020 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality Version: 2x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant