Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more validation rules for view construction (thanks to feedback in #519) #689

Merged
merged 1 commit into from May 19, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented May 17, 2020

Summary

@ruberVulpes
Thank you very much for your great feedback: #519 (comment)

This pull request adds more validation rules in View objects to let developers know errors with more sufficient information. Also, I've updated the views_open API method in WebClient to accept View objects as well.

Requirements (place an x in each [ ])

@seratch seratch added Version: 2x enhancement M-T: A feature request for new functionality web-client v2.6 in-progress labels May 17, 2020
@seratch seratch added this to the 2.6.0 milestone May 17, 2020
@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@61b62fb). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #689   +/-   ##
=========================================
  Coverage          ?   85.40%           
=========================================
  Files             ?       19           
  Lines             ?     2624           
  Branches          ?      249           
=========================================
  Hits              ?     2241           
  Misses            ?      289           
  Partials          ?       94           
Impacted Files Coverage Δ
slack/web/classes/views.py 85.95% <100.00%> (ø)
slack/web/client.py 94.57% <100.00%> (ø)
slack/web/classes/dialog_elements.py 94.44% <0.00%> (ø)
slack/errors.py 100.00% <0.00%> (ø)
slack/web/slack_response.py 98.00% <0.00%> (ø)
slack/web/classes/dialogs.py 83.33% <0.00%> (ø)
slack/web/classes/attachments.py 98.92% <0.00%> (ø)
slack/rtm/client.py 83.33% <0.00%> (ø)
slack/signature/__init__.py 100.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b62fb...6080f1e. Read the comment docs.

@seratch seratch merged commit 0bd61a4 into slackapi:master May 19, 2020
@seratch seratch deleted the more-validations-for-views branch May 19, 2020 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality Version: 2x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant