Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #705 by modifying SlackResponse to consider None value in dict #706

Merged
merged 1 commit into from
May 28, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented May 28, 2020

Summary

This pull request fixes #705 by modifying SlackRepsonse to consider possible None values in req_args dict.

Requirements (place an x in each [ ])

@seratch seratch added Version: 2x bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch web-client labels May 28, 2020
@seratch seratch added this to the 2.6.2 milestone May 28, 2020
@seratch
Copy link
Member Author

seratch commented May 28, 2020

@stevengill @aoberoi
I will be releasing a new patch version including this change tomorrow. Let me know if you have comments or feedback by then 🙇

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #706 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #706      +/-   ##
==========================================
+ Coverage   85.66%   85.68%   +0.02%     
==========================================
  Files          19       19              
  Lines        2630     2634       +4     
  Branches      251      252       +1     
==========================================
+ Hits         2253     2257       +4     
  Misses        282      282              
  Partials       95       95              
Impacted Files Coverage Δ
slack/web/slack_response.py 98.14% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59c8923...f0bb96c. Read the comment docs.

@seratch seratch merged commit 9a261bb into slackapi:master May 28, 2020
@seratch seratch deleted the issue-705-no-param-pagination branch May 28, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch Version: 2x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebClient's paginated API calls may fail with no params (v2.6.0+)
2 participants