Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #728 by adding bytearray support in files_upload (sync mode) #730

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented Jun 23, 2020

Summary

This pull request fixes #728 by adding bytearray type support for file-type parameters. This issue has been an incompatibility issue when using run_async=False (the default) mode since v2.6.0

Requirements (place an x in each [ ])

@seratch seratch added Version: 2x bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented web-client labels Jun 23, 2020
@seratch seratch added this to the 2.7.2 milestone Jun 23, 2020
@seratch seratch self-assigned this Jun 23, 2020
@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #730 into master will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
- Coverage   85.21%   85.15%   -0.07%     
==========================================
  Files          22       22              
  Lines        2800     2802       +2     
  Branches      280      281       +1     
==========================================
  Hits         2386     2386              
- Misses        310      312       +2     
  Partials      104      104              
Impacted Files Coverage Δ
slack/web/base_client.py 71.56% <0.00%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77a125a...bff133c. Read the comment docs.

@seratch seratch merged commit 258806a into slackapi:master Jun 24, 2020
@seratch seratch deleted the issue-728-file-upload-bytes branch June 24, 2020 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 2x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error 'no_file_data' in files_upload method when sending binary data in 'file'
2 participants