api_call should update server state in rtm mode #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 28, 2016
| self.server.attach_channel(kwargs["user"], result["channel"]["id"], []) | ||
| elif method in ('mpim.open', 'groups.create', 'groups.createchild'): | ||
| if "ok" in result and result["ok"]: | ||
| self.server.attach_channel(result['group']['name'], result['group']['id'], []) |
There was a problem hiding this comment.
Both here and line 32 I think you should pass through the members attribute rather than an empty array or passing a None
There was a problem hiding this comment.
I was emulating the style of _client.py:SlackClient:process_changes, which also passes an empty. I'll update it, one moment.
There was a problem hiding this comment.
Yeah, I'm not 100% familiar with the python client yet, so I think you should pass the members array, but that's not canon.
ghost
pushed a commit
that referenced
this pull request
Feb 28, 2016
api_call should update server state in rtm mode
ghost
merged commit 
|
Ok, I'll look to push a 1.0.0 release to pypi later today. Thanks for contributing! |
|
@elementc, nice job! |
c-goosen
pushed a commit
to c-goosen/python-slackclient
that referenced
this pull request
Jun 18, 2019
api_call should update server state in rtm mode
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #73. Also closes #47 by way of solving the same problem that #70 does. I'm closing #70 myself.