Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 2.9.3 release #856

Merged
merged 1 commit into from
Oct 22, 2020
Merged

version 2.9.3 release #856

merged 1 commit into from
Oct 22, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented Oct 20, 2020

Summary

I will be doing the following operations.

python setup.py run_all_tests
python setup.py upload
git checkout main
git merge v2.9.3-release
git push slackapi main
git push slackapi --tag v2.9.3

Category (place an x in each of the [ ])

  • slack.web.WebClient (Web API client)
  • slack.webhook.WebhookClient (Incoming Webhook, response_url sender)
  • slack.web.classes (UI component builders)
  • slack.rtm.RTMClient (RTM client)
  • Documents
  • Others

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python setup.py validate after making the changes.

@seratch seratch added this to the 2.9.3 milestone Oct 20, 2020
@seratch seratch self-assigned this Oct 20, 2020
@seratch seratch mentioned this pull request Oct 20, 2020
12 tasks
@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #856 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #856   +/-   ##
=======================================
  Coverage   87.01%   87.01%           
=======================================
  Files          30       30           
  Lines        3797     3797           
  Branches      340      340           
=======================================
  Hits         3304     3304           
  Misses        344      344           
  Partials      149      149           
Impacted Files Coverage Δ
slack/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0acd1fd...4e45242. Read the comment docs.

Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! All tests pass (except webhook, which isn't configured on my system yet). 🚀

@seratch
Copy link
Member Author

seratch commented Oct 20, 2020

I wanted to fix this issue too. I will work on it later today: #846

@seratch seratch force-pushed the v2.9.3-release branch 2 times, most recently from c38255d to c260ee4 Compare October 21, 2020 20:37
@seratch
Copy link
Member Author

seratch commented Oct 21, 2020

I wanted to fix this issue too. I will work on it later today: #846

Done. I will be releasing this version later today.

@seratch
Copy link
Member Author

seratch commented Oct 22, 2020

I started the release process.

(env_3.8.5) $ python setup.py run_all_tests
running run_all_tests
Installing test dependencies…
/Users/ksera/github/python-slackclient/env_3.8.5/bin/python -m pip install pytest>=5,<6 pytest-cov>=2,<3 codecov>=2,<3 flake8>=3,<4 black psutil
Requirement already satisfied: pytest<6,>=5 in ./env_3.8.5/lib/python3.8/site-packages (5.4.3)
Requirement already satisfied: pytest-cov<3,>=2 in ./env_3.8.5/lib/python3.8/site-packages (2.10.1)
Requirement already satisfied: codecov<3,>=2 in ./env_3.8.5/lib/python3.8/site-packages (2.1.9)
Requirement already satisfied: flake8<4,>=3 in ./env_3.8.5/lib/python3.8/site-packages (3.8.3)
Requirement already satisfied: black in ./env_3.8.5/lib/python3.8/site-packages (19.10b0)
Requirement already satisfied: psutil in ./env_3.8.5/lib/python3.8/site-packages (5.7.2)
Requirement already satisfied: pytest<6,>=5 in ./env_3.8.5/lib/python3.8/site-packages (5.4.3)
Requirement already satisfied: coverage>=4.4 in ./env_3.8.5/lib/python3.8/site-packages (from pytest-cov<3,>=2) (5.2.1)
Requirement already satisfied: py>=1.5.0 in ./env_3.8.5/lib/python3.8/site-packages (from pytest<6,>=5) (1.9.0)
Requirement already satisfied: more-itertools>=4.0.0 in ./env_3.8.5/lib/python3.8/site-packages (from pytest<6,>=5) (8.5.0)
Requirement already satisfied: attrs>=17.4.0 in ./env_3.8.5/lib/python3.8/site-packages (from pytest<6,>=5) (20.2.0)
Requirement already satisfied: pluggy<1.0,>=0.12 in ./env_3.8.5/lib/python3.8/site-packages (from pytest<6,>=5) (0.13.1)
Requirement already satisfied: wcwidth in ./env_3.8.5/lib/python3.8/site-packages (from pytest<6,>=5) (0.2.5)
Requirement already satisfied: packaging in ./env_3.8.5/lib/python3.8/site-packages (from pytest<6,>=5) (20.4)
Requirement already satisfied: toml>=0.9.4 in ./env_3.8.5/lib/python3.8/site-packages (from black) (0.10.1)
Requirement already satisfied: typed-ast>=1.4.0 in ./env_3.8.5/lib/python3.8/site-packages (from black) (1.4.1)
Requirement already satisfied: click>=6.5 in ./env_3.8.5/lib/python3.8/site-packages (from black) (7.1.2)
Requirement already satisfied: pathspec<1,>=0.6 in ./env_3.8.5/lib/python3.8/site-packages (from black) (0.8.0)
Requirement already satisfied: attrs>=17.4.0 in ./env_3.8.5/lib/python3.8/site-packages (from pytest<6,>=5) (20.2.0)
Requirement already satisfied: regex in ./env_3.8.5/lib/python3.8/site-packages (from black) (2020.7.14)
Requirement already satisfied: appdirs in ./env_3.8.5/lib/python3.8/site-packages (from black) (1.4.4)
Requirement already satisfied: mccabe<0.7.0,>=0.6.0 in ./env_3.8.5/lib/python3.8/site-packages (from flake8<4,>=3) (0.6.1)
Requirement already satisfied: pycodestyle<2.7.0,>=2.6.0a1 in ./env_3.8.5/lib/python3.8/site-packages (from flake8<4,>=3) (2.6.0)
Requirement already satisfied: pyflakes<2.3.0,>=2.2.0 in ./env_3.8.5/lib/python3.8/site-packages (from flake8<4,>=3) (2.2.0)
Requirement already satisfied: six in ./env_3.8.5/lib/python3.8/site-packages (from packaging->pytest<6,>=5) (1.15.0)
Requirement already satisfied: pyparsing>=2.0.2 in ./env_3.8.5/lib/python3.8/site-packages (from packaging->pytest<6,>=5) (2.4.7)
Requirement already satisfied: coverage>=4.4 in ./env_3.8.5/lib/python3.8/site-packages (from pytest-cov<3,>=2) (5.2.1)
Requirement already satisfied: requests>=2.7.9 in ./env_3.8.5/lib/python3.8/site-packages (from codecov<3,>=2) (2.24.0)
Requirement already satisfied: idna<3,>=2.5 in ./env_3.8.5/lib/python3.8/site-packages (from requests>=2.7.9->codecov<3,>=2) (2.10)
Requirement already satisfied: chardet<4,>=3.0.2 in ./env_3.8.5/lib/python3.8/site-packages (from requests>=2.7.9->codecov<3,>=2) (3.0.4)
Requirement already satisfied: urllib3!=1.25.0,!=1.25.1,<1.26,>=1.21.1 in ./env_3.8.5/lib/python3.8/site-packages (from requests>=2.7.9->codecov<3,>=2) (1.25.10)
Requirement already satisfied: certifi>=2017.4.17 in ./env_3.8.5/lib/python3.8/site-packages (from requests>=2.7.9->codecov<3,>=2) (2020.6.20)
Running black…
/Users/ksera/github/python-slackclient/env_3.8.5/bin/python -m black /Users/ksera/github/python-slackclient/slack
reformatted /Users/ksera/github/python-slackclient/slack/web/async_client.py
All done! ✨ 🍰 ✨
1 file reformatted, 32 files left unchanged.
Running flake8…
/Users/ksera/github/python-slackclient/env_3.8.5/bin/python -m flake8 /Users/ksera/github/python-slackclient/slack
Running pytest…
/Users/ksera/github/python-slackclient/env_3.8.5/bin/python -m pytest --cov-report=xml --cov=/Users/ksera/github/python-slackclient/slack tests/
====================================================================================================== test session starts ======================================================================================================
platform darwin -- Python 3.8.5, pytest-5.4.3, py-1.9.0, pluggy-0.13.1
rootdir: /Users/ksera/github/python-slackclient, inifile: pytest.ini
plugins: cov-2.10.1, asyncio-0.14.0
collected 269 items                                                                                                                                                                                                             

tests/test_asyncio_event_loops.py .s.                                                                                                                                                                                     [  1%]
tests/rtm/test_rtm_client.py ........                                                                                                                                                                                     [  4%]
tests/rtm/test_rtm_client_functional.py ..............                                                                                                                                                                    [  9%]
tests/signature/test_signature_verifier.py ..........                                                                                                                                                                     [ 13%]
tests/web/test_async_web_client.py ...............                                                                                                                                                                        [ 18%]
tests/web/test_slack_response.py .                                                                                                                                                                                        [ 18%]
tests/web/test_web_client.py .............................                                                                                                                                                                [ 29%]
tests/web/test_web_client_coverage.py .                                                                                                                                                                                   [ 30%]
tests/web/test_web_client_functional.py ..                                                                                                                                                                                [ 30%]
tests/web/test_web_client_issue_829.py ..                                                                                                                                                                                 [ 31%]
tests/web/classes/test_actions.py ........                                                                                                                                                                                [ 34%]
tests/web/classes/test_attachments.py ..........                                                                                                                                                                          [ 38%]
tests/web/classes/test_blocks.py .............................                                                                                                                                                            [ 49%]
tests/web/classes/test_dialogs.py ............                                                                                                                                                                            [ 53%]
tests/web/classes/test_elements.py ........................................                                                                                                                                               [ 68%]
tests/web/classes/test_init.py ..                                                                                                                                                                                         [ 69%]
tests/web/classes/test_objects.py .............................................                                                                                                                                           [ 85%]
tests/web/classes/test_views.py .......................                                                                                                                                                                   [ 94%]
tests/webhook/test_async_webhook.py .......                                                                                                                                                                               [ 97%]
tests/webhook/test_webhook.py ........                                                                                                                                                                                    [100%]

---------- coverage: platform darwin, python 3.8.5-final-0 -----------
Coverage XML written to file coverage.xml


================================================================================================ 268 passed, 1 skipped in 28.75s ================================================================================================
Running pytest…
/Users/ksera/github/python-slackclient/env_3.8.5/bin/python -m pytest --cov-report=xml --cov=/Users/ksera/github/python-slackclient/slack integration_tests/
====================================================================================================== test session starts ======================================================================================================
platform darwin -- Python 3.8.5, pytest-5.4.3, py-1.9.0, pluggy-0.13.1
rootdir: /Users/ksera/github/python-slackclient, inifile: pytest.ini
plugins: cov-2.10.1, asyncio-0.14.0
collected 88 items                                                                                                                                                                                                              

integration_tests/rtm/test_issue_530.py ..                                                                                                                                                                                [  2%]
integration_tests/rtm/test_issue_558.py s                                                                                                                                                                                 [  3%]
integration_tests/rtm/test_issue_569.py s.                                                                                                                                                                                [  5%]
integration_tests/rtm/test_issue_605.py s                                                                                                                                                                                 [  6%]
integration_tests/rtm/test_issue_611.py s                                                                                                                                                                                 [  7%]
integration_tests/rtm/test_issue_631.py ss                                                                                                                                                                                [ 10%]
integration_tests/rtm/test_issue_701.py ss                                                                                                                                                                                [ 12%]
integration_tests/rtm/test_rtm_client.py ..                                                                                                                                                                               [ 14%]
integration_tests/web/test_admin_conversations.py ..                                                                                                                                                                      [ 17%]
integration_tests/web/test_admin_conversations_restrictAccess.py ..                                                                                                                                                       [ 19%]
integration_tests/web/test_admin_usergroups.py ..                                                                                                                                                                         [ 21%]
integration_tests/web/test_async_web_client.py ........                                                                                                                                                                   [ 30%]
integration_tests/web/test_calls.py ..                                                                                                                                                                                    [ 32%]
integration_tests/web/test_issue_378.py ..                                                                                                                                                                                [ 35%]
integration_tests/web/test_issue_480.py ....                                                                                                                                                                              [ 39%]
integration_tests/web/test_issue_560.py ....                                                                                                                                                                              [ 44%]
integration_tests/web/test_issue_594.py ..                                                                                                                                                                                [ 46%]
integration_tests/web/test_issue_654.py ..                                                                                                                                                                                [ 48%]
integration_tests/web/test_issue_670.py ..                                                                                                                                                                                [ 51%]
integration_tests/web/test_issue_672.py ....                                                                                                                                                                              [ 55%]
integration_tests/web/test_issue_677.py ..                                                                                                                                                                                [ 57%]
integration_tests/web/test_issue_714.py ..                                                                                                                                                                                [ 60%]
integration_tests/web/test_issue_728.py ..                                                                                                                                                                                [ 62%]
integration_tests/web/test_issue_770.py ..                                                                                                                                                                                [ 64%]
integration_tests/web/test_issue_809.py ..                                                                                                                                                                                [ 67%]
integration_tests/web/test_remote_file_replacement.py .                                                                                                                                                                   [ 68%]
integration_tests/web/test_web_client.py .........s........                                                                                                                                                               [ 88%]
integration_tests/webhook/test_async_webhook.py .....                                                                                                                                                                     [ 94%]
integration_tests/webhook/test_webhook.py .....                                                                                                                                                                           [100%]

======================================================================================================= warnings summary ========================================================================================================
integration_tests/web/test_async_web_client.py::TestAsyncWebClient::test_uploading_binary_files_async
  /Users/ksera/.pyenv/versions/3.8.5/lib/python3.8/asyncio/base_events.py:641: RuntimeWarning: coroutine 'RTMClient._dispatch_event' was never awaited
    self._ready.clear()

-- Docs: https://docs.pytest.org/en/latest/warnings.html

---------- coverage: platform darwin, python 3.8.5-final-0 -----------
Coverage XML written to file coverage.xml

===================================================================================== 79 passed, 9 skipped, 1 warning in 292.50s (0:04:52) ======================================================================================
(env_3.8.5) $ 

@seratch seratch merged commit 4e45242 into slackapi:main Oct 22, 2020
@github-pages github-pages bot temporarily deployed to github-pages October 22, 2020 00:34 Inactive
@seratch seratch deleted the v2.9.3-release branch December 1, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants