Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #846 RTMClient does not pass timeout value to WebClient #857

Merged
merged 1 commit into from Oct 21, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented Oct 21, 2020

Summary

This pull request fixes #846

Category (place an x in each of the [ ])

  • slack.web.WebClient (Web API client)
  • slack.webhook.WebhookClient (Incoming Webhook, response_url sender)
  • slack.web.classes (UI component builders)
  • slack.rtm.RTMClient (RTM client)
  • Documents
  • Others

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python setup.py validate after making the changes.

@seratch seratch added Version: 2x bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented rtm-client labels Oct 21, 2020
@seratch seratch added this to the 2.9.3 milestone Oct 21, 2020
@seratch seratch self-assigned this Oct 21, 2020
@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #857 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #857   +/-   ##
=======================================
  Coverage   87.01%   87.01%           
=======================================
  Files          30       30           
  Lines        3797     3797           
  Branches      340      340           
=======================================
  Hits         3304     3304           
  Misses        344      344           
  Partials      149      149           
Impacted Files Coverage Δ
slack/rtm/client.py 83.82% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 580a5ab...e1eebb3. Read the comment docs.

@seratch seratch merged commit f8ccc04 into slackapi:main Oct 21, 2020
@seratch seratch deleted the issue-846-rtm-timeouts branch October 21, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented rtm-client Version: 2x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTMClient does not pass timeout value to WebClient
3 participants