Non-list list-like parameters passed to API call are not serialized to JSON

[jstlaurent]

Description

When sending a list-like parameter to an API method (attachments to chat.postMessage, for example), only actual list and dict are serialized to JSON. Sending a tuple is not serialized and the attachments are disregarded by the Slack API.

What type of issue is this? (place an x in one of the [ ])

• bug
• enhancement (feature request)
• question
• documentation related
• testing related
• discussion

Requirements (place an x in each of the [ ])

• I've read and understood the Contributing guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.
• I've searched for any related issues and avoided creating a duplicate issue.

---

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Reproducible in:

slackclient version: 1.2.1

python version: 2.7.14

OS version(s): macOS 10.13.5

Steps to reproduce:

1. Instantiate a SlackClient with a proper token
2. Call the api_call method on the client, for the chat.postMessage API endpoint, with the following parameters:

client.api_call(
    'chat.postMessage', 
    channel='<valid_channel_id>', 
    text='Message text', 
    attachments=(
        {
            "text": "First attachment",
            "color": "#ffa600",
        }, 
        {
            "text": "Second attachment",
            "color": "#ffa600",
        }
    )
)

3. Read the message posted

Expected result:

The message is displayed with two attachments.

Actual result:

Only the message text is displayed.

Potential fix:

I believe the type checking done in slackrequest.py could be loosened so that tuples and other iterables could be supported as well.

[Roach]

Thanks for catching this. We'll add tuple to the list or attachment iterables.

https://github.com/slackapi/python-slackclient/blob/master/slackclient/slackrequest.py#L93-L96

Can you think of any more data types that should be in that list? 🤔

[jstlaurent]

Thanks for getting back to me! I meant to send a PR along with the report, but things got a bit hectic. Sorry it took me so long. I added support for tuples, sets and generators in the PR. Let me know if that's too much and I'll narrow it down.

[seratch]

This project no longer supports version 1.x as we've described here. Allow me to close this now.