-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input includes as an array (Fix #16) #22
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
+ Coverage 56.76% 64.57% +7.80%
==========================================
Files 5 6 +1
Lines 229 271 +42
==========================================
+ Hits 130 175 +45
+ Misses 99 96 -3 ☔ View full report in Codecov by Sentry. |
@filmaj Please review |
@SherbetLemon47 I'm not sure that this approach works w/ YAML arrays/lists. Check out this article and scroll down to "Defining Arrays in YAML." Ideally we should support either block or flow arrays in YAML for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some tests, I suppose the new approach works both types of YAML arrays. Reworked comment function to support extensions arrays. For a better YAML to JSON approach I think would have to go for a library.
This reverts commit 3f67dba.
Even though I pushed a commit. I've come to find that github actions doesn't actually support arrays as input. Source- Here. Wrapping the strings in double quotes does work i.e things like "['src','test']", etc. but I don't think a proper array implementation is possible But the approach mentioned above, the one with multiline strings does work with this. |
@filmaj waiting for a review, moved stubs to a separate file, so further testing on other features would require merging or discarding the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I left some comments, mostly about refactoring, organization and some test questions, but overall looking great. Thank you so much for working on this!
Added all the requested changes and some really overkill tests. Please review. @filmaj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nicely done! Many thanks for your hard work here 🙇
Summary
Describe the goal of this PR. Mention any related Issue numbers.
Fixes #16.
Requirements (place an
x
in each[ ]
)