Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

Fix compiler error in example app #629

Merged
merged 2 commits into from
Sep 26, 2017
Merged

Fix compiler error in example app #629

merged 2 commits into from
Sep 26, 2017

Conversation

BasThomas
Copy link
Contributor

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
  • I've written tests to cover the new code and functionality included in this PR.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

Fixes a compiler error in the example project

Test strategy

Run the Swift example and verify that it builds on Xcode 9

@@ -474,7 +474,7 @@ extension MessageViewController {
}
}

override func shouldProcessText(forAutoCompletion text: String) -> Bool {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. shouldProcessText(forAutoCompletion text: String was actually deprecated in favour of shouldProcessTextForAutoCompletion().
Mind updating to that method instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. But how could it be causing a compiler error if it was deprecated? That doesn't sound right?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it was not longer defined on the super class, meaning we should have not been using override anymore. My bad, I always forget to check that sample project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI? :)

Copy link

@dzenbot dzenbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@dzenbot dzenbot merged commit 4c74cba into slackhq:master Sep 26, 2017
@BasThomas BasThomas deleted the compiler-error-example-app branch September 26, 2017 18:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants