Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try using dependency resolution for robolectric jars #424

Closed
ZacSweers opened this issue Jun 28, 2023 · 0 comments · Fixed by #425
Closed

Try using dependency resolution for robolectric jars #424

ZacSweers opened this issue Jun 28, 2023 · 0 comments · Fixed by #425

Comments

@ZacSweers
Copy link
Collaborator

We could make a different configuration for each jar and let gradle do the heavy lifting for us, avoiding the need for #423 and #422
@ZacSweers ZacSweers mentioned this issue Jun 28, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 29, 2023
@ZacSweers
Switch to using detached configurations for robolectric jar downloads (…
f174372 
…#425)

Few benefits
- It uses the same dependency resolution settings we have (i.e.
artifactory repositories work out of the box)
- Lets gradle to the heavy lifting with both downloading and caching
downloads
- Simpler setup for us with task up-to-date ness. Now we just always run
the task but the most it every does is copy files. Extremely fast.

Resolves #423, resolves #422, resolves #424

<!--
  ⬆ Put your description above this! ⬆

  Please be descriptive and detailed.
  
Please read our [Contributing
Guidelines](https://github.com/tinyspeck/slack-gradle-plugin/blob/main/.github/CONTRIBUTING.md)
and [Code of Conduct](https://slackhq.github.io/code-of-conduct).

Don't worry about deleting this, it's not visible in the PR!
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to using detached configurations for robolectric jar downloads slackhq/foundry
1 participant
@ZacSweers