Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding set all instances func to restore db state from json #36

Merged
merged 3 commits into from
Oct 21, 2019
Merged

Adding set all instances func to restore db state from json #36

merged 3 commits into from
Oct 21, 2019

Conversation

jzimmerman95
Copy link
Contributor

This is to restore instances state for fixtures within webapp! PR that's still WIP: https://checkpoint.tinyspeck.com/ghe/slack/webapp/pulls/6613

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

ssandler
ssandler reviewed Oct 21, 2019
View reviewed changes
Copy link
Contributor

@ssandler ssandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a comment here clarifying that this blows away absolutely everything :-)

Also - indention looks like it might be off?

@ssandler ssandler merged commit 06884b2 into master Oct 21, 2019
@ssandler ssandler deleted the jayz_add_set_all_instances_func branch January 5, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssandler ssandler ssandler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jzimmerman95 @CLAassistant @ssandler @jayztest123