Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: make network identify-able #436

Open
My1 opened this issue Apr 4, 2021 · 4 comments
Open

Windows: make network identify-able #436

My1 opened this issue Apr 4, 2021 · 4 comments
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone

Comments

@My1
Copy link

My1 commented Apr 4, 2021

Windows has a hard time dealing with several things when it cannot "identify" a network. no idea how it does "identify" a network but for example you cannot easily set a net as private if your network is not able to be identified (either you have to make it non every reboot or you run around with a security risk), and therefore easily able to get the network from nebula into private without any bigger issues.

@caguiclajmg
Copy link

This can be easily changed with a single PS command:

Set-NetConnectionProfile -Name "Local Area Connection 3" -NetworkCategory Public/Private

I don't think nebula itself should be fiddling with this though.

@My1
Copy link
Author

My1 commented Apr 5, 2021

as I said, this Powershell solution is not permanent and would need to be applied after every boot, similar to here

https://superuser.com/questions/1441412/windows-10-set-netconnectionprofile-permanent

If windows could "identify" the network, it would not have that issue.

aaronkollasch added a commit to aaronkollasch/nebula that referenced this issue Apr 14, 2021
Uses Set-NetConnectionProfile to make the network private when the connection is created.
Prints stderr from the command to assist debugging, and does not fail if Set-NetConnectionProfile fails.
No config option included, so not intended as a general solution.

Fixes slackhq#436
@aaronkollasch
Copy link

I made a version of tun_windows.go that sets the connection to private as the setting is not permanent otherwise.

It's a hack-y solution as it doesn't include a config option, and I agree that it may not belong in nebula itself, but if you are able to compile your own executable and really want a solution, this might help.

@My1
Copy link
Author

My1 commented Apr 14, 2021

well at least zerotier which does kinda similar things makes its networks in a way windows can identify them and thereby set them accordingly, not sure how hamachi and others act. but the fact it there is not really a good way of making the network private that does not.

  1. need CLI
  2. revert on every restart or whatever
  3. is a very bad idea in terms of security

@nbrownus nbrownus added this to the v1.6.0 milestone Nov 16, 2021
@nbrownus nbrownus modified the milestones: v1.6.0, v1.7.0 Apr 18, 2022
@nbrownus nbrownus modified the milestones: v1.7.0, v1.8.0 Mar 27, 2023
@johnmaguire johnmaguire added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Apr 21, 2023
@nbrownus nbrownus modified the milestones: v1.8.0, v1.9.0 Oct 30, 2023
@nbrownus nbrownus modified the milestones: v1.9.0, v1.10.0 Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Development

No branches or pull requests

5 participants