Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging around peer activity #84

Closed
nbrownus opened this issue Dec 11, 2019 · 0 comments · Fixed by #200
Closed

Improve logging around peer activity #84

nbrownus opened this issue Dec 11, 2019 · 0 comments · Fixed by #200
Labels
enhancement New feature or request
Milestone
v1.2.0

Comments

@nbrownus
Copy link
Collaborator

Any place that we log vpnIp we should also log host from the related certificate to make it easier to understand.
@nbrownus nbrownus added this to the v1.1.0 milestone Dec 11, 2019
@nbrownus nbrownus added the enhancement New feature or request label Dec 11, 2019
@wadey wadey modified the milestones: v1.1.0, v1.2.0 Jan 21, 2020
wadey added a commit to wadey/nebula that referenced this issue Mar 3, 2020
@wadey
log certName along side vpnIp
0108231 
This change adds a new helper, `(*HostInfo).logger()`, that starts a new
logrus.Entry with `vpnIp` and `certName`. We don't use the helper inside
of handshake_ix though since the certificate has not been attached to
the HostInfo yet.

Fixes: slackhq#84
wadey added a commit to wadey/nebula that referenced this issue Mar 3, 2020
@wadey
log certName along side vpnIp
4ecd487 
This change adds a new helper, `(*HostInfo).logger()`, that starts a new
logrus.Entry with `vpnIp` and `certName`. We don't use the helper inside
of handshake_ix though since the certificate has not been attached to
the HostInfo yet.

Fixes: slackhq#84
wadey added a commit to wadey/nebula that referenced this issue Mar 3, 2020
@wadey
log certName alongside vpnIp
a3e8537 
This change adds a new helper, `(*HostInfo).logger()`, that starts a new
logrus.Entry with `vpnIp` and `certName`. We don't use the helper inside
of handshake_ix though since the certificate has not been attached to
the HostInfo yet.

Fixes: slackhq#84
@wadey wadey mentioned this issue Mar 3, 2020
Merged
nbrownus pushed a commit that referenced this issue Apr 6, 2020
@wadey
log certName alongside vpnIp (#200)
b4f2f7c 
This change adds a new helper, `(*HostInfo).logger()`, that starts a new
logrus.Entry with `vpnIp` and `certName`. We don't use the helper inside
of handshake_ix though since the certificate has not been attached to
the HostInfo yet.

Fixes: #84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

log certName alongside vpnIp wadey/nebula
2 participants
@wadey @nbrownus