Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to trigger punch backs via lighthouse #394

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Conversation

nbrownus
Copy link
Collaborator

@nbrownus nbrownus commented Mar 1, 2021

Rebind is called by the controlling program when a network interface change is detected (iOS only for now, soon to be others). This code adds a way to signal through the lighthouse that a remote should punch back on a possible new IP for the local, greatly improving the roaming story.

Before this change, roaming on a routable ip generally meant the tunnel would have to die and be stood back up.

Copy link
Member

@wadey wadey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. The race detector will complain about the Interface.rebindCount, but we know there isn't actually a race issue there so I'm okay with it 👍.

@nbrownus nbrownus merged commit b6234ab into master Mar 2, 2021
@nbrownus nbrownus deleted the rebind-update branch March 2, 2021 01:06
@wadey wadey added this to the v1.4.0 milestone Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants