Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nss-lookup to the systemd wants #791

Merged
merged 4 commits into from
Dec 19, 2022
Merged

Add nss-lookup to the systemd wants #791

merged 4 commits into from
Dec 19, 2022

Conversation

Fale
Copy link
Contributor

@Fale Fale commented Dec 10, 2022 •
edited
Loading

Ensure DNS is running before starting nebula.
Fixes #745. Thanks a lot @johnmaguire for the suggestion :-)
Closes #792
Fixes #797

@johnmaguire johnmaguire mentioned this pull request Dec 12, 2022
Closed
@Fale
Copy link
Contributor Author

Fale commented Dec 17, 2022

I've added the fix for #797, merged #792 changes and aligned the files, if not the Before=sshd.service in Arch, even if from what I've seen in the last few days it to should be safe to do so that we have all the service files aligned :-)

wadey
wadey approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@wadey wadey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issues with this, and it should help a lot with problems folks have 👍

@wadey wadey added this to the v1.7.0 milestone Dec 19, 2022
@johnmaguire
Copy link
Collaborator

This PR also fixes #176 and #372.

@johnmaguire johnmaguire mentioned this pull request Dec 19, 2022
Merged
@wadey wadey merged commit 3ae242f into slackhq:master Dec 19, 2022
@johnmaguire
Copy link
Collaborator

Thanks for the work on this @Fale!

@johnmaguire johnmaguire mentioned this pull request Mar 6, 2023
Closed
@johnmaguire johnmaguire mentioned this pull request May 18, 2023
Closed
apeters1827 pushed a commit to oneclick-ag/nebula that referenced this pull request Jul 4, 2023
@Fale @johnmaguire
Add nss-lookup to the systemd wants (slackhq#791)
2bd5c6c 
* Add nss-lookup to the systemd wants to ensure DNS is running before starting nebula

* Add Ansible & example service scripts

* Fix slackhq#797

* Align Ansible scripts and examples

Co-authored-by: John Maguire <contact@johnmaguire.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wadey wadey wadey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.7.0
3 participants
@Fale @johnmaguire @wadey