Integrate buildconfig plugin to project to replace old version templates work #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old API is now deprecated
…ties and Kotlin file.
This commit renames the agp-handler-80 directory to agp-handler-82. Additionally, it updates the references to agp-handler-80 to now point to agp-handler-82 in the settings.gradle.kts file and the slack-plugin/build.gradle.kts file. This ensures that the correct version of the agp-handler is being used in the project.
linhpha
reviewed
Dec 8, 2023
| @@ -1,9 +0,0 @@ | |||
| @file:JvmName("KotlinBuildConfig") | |||
There was a problem hiding this comment.
Does this reference still work with this file removed?
https://github.com/slackhq/slack-gradle-plugin/pull/677/files#diff-c0dfa6bc7a8685217f70a860145fbdf416d449eaff052fa28352c5cec1a98c06R180.
There was a problem hiding this comment.
That's different than this file actually, they're just named the same. That other def is here: https://github.com/slackhq/slack-gradle-plugin/pull/677/files#diff-c0dfa6bc7a8685217f70a860145fbdf416d449eaff052fa28352c5cec1a98c06R122
ZacSweers
commented
Dec 11, 2023
| project.pluginManager.withPlugin("com.github.gmazzo.buildconfig") { | ||
| configure<BuildConfigExtension> { | ||
| buildConfigField("String", "KOTLIN_VERSION", "\"$kotlinVersion\"") | ||
| // Using Any here due to https://github.com/gmazzo/gradle-buildconfig-plugin/issues/9 |
There was a problem hiding this comment.
PR'd a hopeful fix here gmazzo/gradle-buildconfig-plugin#98
linhpha
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a nicer plugin to handle buildconfig constants