slack-vitess-r15.0.5: add slack_cross_cell custom durability policy
#266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
timvaillancourt
changed the title
slack-vitess-r15.0.5: add slack_cross_cell custom durability policy slack-vitess-r15.0.5: add slack_cross_cell custom durability policy
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
timvaillancourt
added
upstream-backport
…s-r15.0.5 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
* Update all the Go dependencies This seems to work for the basics just fine, so let's have CI take a run at this as well to update these. Only one small update to the Azure blob storage handling seems needed so far. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Use correct proto comparisons We're using `reflect.DeepEqual` or `testify` helpers that essentially use that in a number of places are comparing protobufs. This is not supported though, protobufs are not comparable with `reflect.DeepEqual`. This is exposed because of the tiny patch bump of protobuf which changes some internal optimization of how it initializes protobufs that breaks all this. Instead, move to the appropriate helpers here. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
|
Thanks for the contribution! Before we can merge this, we need @dbussink to sign the Salesforce Inc. Contributor License Agreement. |
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
This reverts commit 18faa1e.
…s-r15.0.5 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
tanjinx
approved these changes
May 22, 2024
timvaillancourt
merged commit a912583
into
slack-vitess-r15.0.5
196 of 197 checks passed
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the custom
slack_cross_cellDurability Policy to our v15 release to allow the flexibility in promotion rules and semi-sync ackers that we expect with our deployment todayThe durability policy code was added to a new, private repo so it can be stored independent to this code: https://github.com/slackhq/vitess-addons/tree/v0.15.3/go/durability
Related Issue(s)
Checklist
Deployment Notes