Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack-15.0: fix private repo git config in docker build #367

Merged
merged 1 commit into from
May 23, 2024

Conversation

timvaillancourt
Copy link
Member

Description

This PR should fix access issues in our Jenkins build due to using a Durability Policy in a private repo, and the Docker build being unprepared for this:

2024.05.22 19:42:46 #8 4.691 go: downloading github.com/mattn/go-colorable v0.1.6
2024.05.22 19:42:46 #8 4.694 go: downloading github.com/remyoudompheng/bigfft v0.0.0-20200410134404-eec4a21b6bb0
2024.05.22 19:42:46 #8 4.741 go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
2024.05.22 19:42:46 #8 4.741 go: downloading github.com/hashicorp/go-immutable-radix v1.1.0
2024.05.22 19:42:46 #8 4.805 go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
2024.05.22 19:42:47 #8 5.671 go/vt/vtctl/reparentutil/slack_cross_cell_shim.go:3:8: reading github.com/slackhq/vitess-addons/go.mod at revision v0.15.3: git ls-remote -q origin in /go/pkg/mod/cache/vcs/deddcb84177463a570ad3cac1ad9ff1e94bf4f985fbe6cc27416617e75330028: exit status 128:
2024.05.22 19:42:47 #8 5.671 	fatal: could not read Username for 'https://github.com/': terminal prompts disabled
2024.05.22 19:42:47 #8 5.671 Confirm the import path was entered correctly.
2024.05.22 19:42:47 #8 5.671 If this is a private repository, see https://golang.org/doc/faq#git_https for additional information.
2024.05.22 19:42:47 #8 5.674 make: *** [Makefile:85: build] Error 1
2024.05.22 19:42:48 #8 ERROR: process "/bin/sh -c make build" did not complete successfully: exit code: 2
2024.05.22 19:42:48 ------

This issue was introduced in #266 where I should have updated these Dockerfiles 馃う

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@github-actions github-actions bot added this to the v15.0.5 milestone May 23, 2024
@timvaillancourt timvaillancourt marked this pull request as ready for review May 23, 2024 22:19
@timvaillancourt timvaillancourt requested a review from a team as a code owner May 23, 2024 22:19
@timvaillancourt timvaillancourt merged commit 1aed880 into slack-15.0 May 23, 2024
194 of 195 checks passed
@timvaillancourt timvaillancourt deleted the fix-docker-build-slack-15.0 branch May 23, 2024 23:45
timvaillancourt added a commit that referenced this pull request May 28, 2024
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
timvaillancourt added a commit that referenced this pull request May 28, 2024
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants