Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack-15.0: backport vtgate buffer fix vitessio/vitess#13856 #377

Merged
merged 3 commits into from
May 28, 2024
Merged

slack-15.0: backport vtgate buffer fix vitessio/vitess#13856 #377

merged 3 commits into from
May 28, 2024

Conversation

timvaillancourt
Copy link
Member

Description

This PR replaces #322 using git cherry-pick to preserve commit history

Backports:

  1. bugfix: fix nil pointer in vtgate on topo connection error vitessio/vitess#13010
  2. VTGate Buffering: Use a more accurate heuristic for determining if we're doing a reshard vitessio/vitess#13856

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

olyazavr and others added 2 commits May 28, 2024 20:59
@olyazavr @timvaillancourt
bugfix: fix nil pointer in vtgate on topo connection error (vitessio#…
53605bf 
…13010)

* fix nil pointer in vtgate on topo connection error

Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>

* add test

Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>

* fix year

Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>

---------

Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>
Co-authored-by: Olga Shestopalova <oshestopalova@hubspot.com>
@mattlord @timvaillancourt
VTGate Buffering: Use a more accurate heuristic for determining if we…
b3262d7 
…'re doing a reshard (vitessio#13856)

Signed-off-by: Matt Lord <mattalord@gmail.com>
@timvaillancourt timvaillancourt requested a review from a team as a code owner May 28, 2024 19:06
@salesforce-cla Salesforce CLA
Copy link

Thanks for the contribution! Before we can merge this, we need @olyazavr @mattlord to sign the Salesforce Inc. Contributor License Agreement.

@github-actions github-actions bot added this to the v15.0.5 milestone May 28, 2024
@timvaillancourt timvaillancourt mentioned this pull request May 28, 2024
Closed
4 tasks
@timvaillancourt timvaillancourt merged commit 36378c1 into slack-15.0 May 28, 2024
193 of 194 checks passed
@timvaillancourt timvaillancourt deleted the bp-pr13856-slack-15.0 branch May 28, 2024 22:13
@timvaillancourt timvaillancourt mentioned this pull request Jun 4, 2024
Closed
4 tasks
@tanjinx tanjinx mentioned this pull request Jun 28, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roderickyao roderickyao roderickyao approved these changes

Assignees
No one assigned
Labels
cla:missing upstream-backport An upstream backport v15 v17-backport v18-backport
Projects
None yet
Milestone
v15.0.5
Development

Successfully merging this pull request may close these issues.
4 participants
@timvaillancourt @roderickyao @olyazavr @mattlord