forked from vitessio/vitess
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slack-vitess-r14.0.5
: backport vitessio/vitess#10956, use go 1.20.4
#85
Closed
timvaillancourt
wants to merge
11
commits into
slack-vitess-r14.0.5
from
pr-10956-slack-vitess-r14.0.5
Closed
slack-vitess-r14.0.5
: backport vitessio/vitess#10956, use go 1.20.4
#85
timvaillancourt
wants to merge
11
commits into
slack-vitess-r14.0.5
from
pr-10956-slack-vitess-r14.0.5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cleanup usage of go.rice in favor of go:embed The usage of go.rice predates the availability of go:embed, but we should switch to using go:embed instead to ship specific assets like config files that we need. go.rice is also incompatible with Go 1.19 and while it might see a fix in the future, it seems better to go with the recommended Go approach that is available these days. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Move vtctld to also use `go embed` instead of go.rice Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Remove last rice-box related comments Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Remove config moving This right now breaks building the actual tests since the tests might also end up loading the regular code which has a `go embed` and refers to the package with the config embeds. This doesn't mean that the config isn't properly included in the binaries. Also with using `go embed` we have a build time dependency on the files and we always know the latest is included, so we don't have the issue of potentially outdated files either. All in all, it seems simplest to remove this logic and trust that Go itself works as advertised. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Thanks for the contribution! Before we can merge this, we need @dbussink to sign the Salesforce Inc. Contributor License Agreement. |
maksimov
force-pushed
the
pr-10956-slack-vitess-r14.0.5
branch
from
May 25, 2023 22:29
50b94ae
to
697c6f7
Compare
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
timvaillancourt
changed the title
May 26, 2023
slack-vitess-r14.0.5
: backport vitessio/vitess#10956, use go 1.19slack-vitess-r14.0.5
: backport vitessio/vitess#10956, use go 1.20.4
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
maksimov
force-pushed
the
pr-10956-slack-vitess-r14.0.5
branch
5 times, most recently
from
June 7, 2023 14:06
fab07b3
to
7ebbc4f
Compare
maksimov
force-pushed
the
pr-10956-slack-vitess-r14.0.5
branch
from
June 7, 2023 19:23
7ebbc4f
to
7d4955e
Compare
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
This PR was closed because it has been stale for 7 days with no activity. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1.191.20 to resolve security ticketsRelated Issue(s)
vitessio#10956
Checklist
Deployment Notes