Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ADC python code using list Variables #1097

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Fix ADC python code using list Variables #1097

merged 2 commits into from
Jul 13, 2023

Conversation

slacrherbst
Copy link
Contributor

@slacrherbst slacrherbst commented Jul 12, 2023 •
edited
Loading

The previous code had mistakes in the list variable mappings.

Best to compare to the original rawWrite code:

https://github.com/slaclab/surf/blob/master/python/surf/devices/ti/_Adc32Rf45.py

@slacrherbst slacrherbst requested a review from ruck314 July 12, 2023 05:59
@ruck314 ruck314 mentioned this pull request Jul 12, 2023
Merged
@ruck314 ruck314 merged commit d693bce into pre-release Jul 13, 2023
3 checks passed
@ruck314 ruck314 deleted the rogue_v6 branch July 13, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruck314 ruck314 ruck314 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slacrherbst @ruck314