Skip to content

Commit

Permalink
chore: change workflow name (#525)
Browse files Browse the repository at this point in the history
secureli-437

Changes the name of the integration test workflow to smoke test. 
According to [the issue raised on stack overflow
here](https://stackoverflow.com/questions/57927115/delete-a-workflow-from-github-actions#57927776),
and [the github documentation
here](https://docs.github.com/en/actions/managing-workflow-runs/deleting-a-workflow-run),
the old integration test workflow history should remain. Workflow runs
must be deleted manually, and renaming the files should create a new
workflow.

If the Integration Test workflow is still active after this PR is
merged, it should be disabled. [How to disable a
workflow](https://docs.github.com/en/actions/using-workflows/disabling-and-enabling-a-workflow#disabling-a-workflow)


## Changes
* Rename .github/workflows/integration_testing.yml to
.github/workflows/smoke_testing.yml
* Updated workflow name to Smoke Testing
* Updated job name and file reference to Smoke Testing in
.github/workflows/publish.yml

## Testing
* Not sure how to test, since this workflow will only run on main and be
created when this PR is merged.


## Clean Code Checklist
<!-- This is here to support you. Some/most checkboxes may not apply to
your change -->
- [X] Meets acceptance criteria for issue
- [ ] New logic is covered with automated tests
- [ ] Appropriate exception handling added
- [ ] Thoughtful logging included
- [ ] Documentation is updated
- [ ] Follow-up work is documented in TODOs
- [ ] TODOs have a ticket associated with them
- [x] No commented-out code included


<!--
Github-flavored markdown reference:
https://docs.github.com/en/get-started/writing-on-github
-->
  • Loading branch information
rt-slalom committed Apr 19, 2024
1 parent e2e3095 commit be4a1af
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,11 @@ jobs:
run: ./scripts/secureli-deployment.sh


integration-testing:
name: Integration Testing
smoke-testing:
name: Smoke Testing
needs: [ build-test, secureli-release, secureli-publish, deploy ]
if: |
always() &&
(needs.secureli-publish.result == 'success' || needs.secureli-publish.result == 'skipped') &&
(needs.deploy.result == 'success' || needs.deploy.result == 'skipped')
uses: ./.github/workflows/integration_testing.yml
uses: ./.github/workflows/smoke_testing.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
# This workflow pulls the published seCureLI packages from Pypi & Homebrew & executes them against a test repo
# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python

# TODO we should rename these to smoke tests but I'd rather hold off on doing that for now
# since renaming the workflow/action might cause us to lose history for executions under the old name
name: Integration Testing
name: Smoke Testing

on:
workflow_call:
Expand Down

0 comments on commit be4a1af

Please sign in to comment.