Allow direct installation of downloaded APKs #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maniac103 I see this has been parked for quite some time, are there any doubts/uncertainties around the proposed changes? |
|
Uh, I completely forgot about this. I'd prefer to keep the class renaming out, or at least keep the old name for |
Removed the change, let me know if there's anything else |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a required permission to the manifest so that downloaded APKs can be installed directly by tapping on the download notification on Android 6+.
I've also extracted download-related methods that were in
UiUtilsin a separateDownloadUtilsclass (I felt they were out of place while looking at the code)and renamed the receiver responsibile for intercepting clicks on pending download notifications.Fixes #1067