Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improve WebView styling #1180

Merged
merged 7 commits into from
May 19, 2022

Conversation

Fs00
Copy link
Contributor

@Fs00 Fs00 commented Feb 13, 2022

This PR makes more improvements to WebView styles, with a few more fixes and tweaks:

  • fix printing of Markdown previews, which was not working anymore after leveraging JavascriptInterfaces more extensively
  • change background color of WebViews to be exactly the same as the app UI, by setting it to transparent.
    Previously it was set to a slightly different shade of grey compared to the other screens.
  • improve CSS styles, particularly spacing and text contrast in dark theme as you can see below:
BeforeAfter
  • markdown CSS styling is now also applied to wiki pages and GH blog posts. It makes them look considerably better, as images do not overflow the page anymore:
BeforeAfter
  • images will now fit the screen size in file viewer (previously they were zoomed in if bigger than the screen)
  • extra: disabled filesystem access in WebViews for improved security. It is never used by the app as far as I've seen.

@maniac103 maniac103 merged commit 9402f96 into slapperwan:master May 19, 2022
@Fs00 Fs00 deleted the better-webview-styling branch May 19, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants