This repository has been archived by the owner on Sep 1, 2023. It is now read-only.
Make server self destruct #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check every 100ms if it has started with an upper limit of 5s Previously we checked after 0.1s, 0.3s, 0.6s and 1s only, with a slower start ending up causing an exception later
|
This depends on (and includes) #67 |
instead of twice per second :P
|
LOL, I never thought of this 👍 |
|
@slashmili This make error with elixir 1.2.3 |
|
@lATAl can you provide the errors? |
|
When I run ```elixir
~/.dotfiles/vim/vendor/alchemist.vim/alchemist-server/run.exs --env=dev
--listen``` for debug. Output an error
```
(EXIT from #PID<0.47.0>) shutdown: failed to start child: SelfDestructTimer
** (EXIT) an exception was raised:
** (MatchError) no match of right hand side value: {:error,
{:undef, [{DateTime, :utc_now, [], []}, {SelfDestructTimer, :now, 0, [file:
'/Users/tuan/.dotfiles/vim/vendor/alchemist.vim/alchemist-server/lib/self_destruct_timer.ex',
line: 24]}, {Agent.Server, :init, 1, [file: 'lib/agent/server.ex', line:
8]}, {:gen_server, :init_it, 6, [file: 'gen_server.erl', line: 328]},
{:proc_lib, :init_p_do_apply, 3, [file: 'proc_lib.erl', line: 240]}]}}
/Users/tuan/.dotfiles/vim/vendor/alchemist.vim/alchemist-server/lib/self_destruct_timer.ex:4:
SelfDestructTimer.start_link/0
```
I think the reason is that DateTime is only available from version 1.3
…On Thu, Mar 30, 2017 at 2:17 PM, Milad ***@***.***> wrote:
@lATAl <https://github.com/lATAl> can you provide the errors?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#66 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABl5HIeKIoVslyckpE3jFqFIt2HpCxQNks5rq1bxgaJpZM4KqiiX>
.
|
|
@lATAl Ah! that's correct :( Well we can check if elixir is older and don't enable this feature, what do you think? |
|
@slashmili Yes. Can you do that? |
slashmili
added a commit
that referenced
this pull request
Apr 3, 2017
|
@lATAl can you check |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.