Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow main-h1-bg, logo-margin-top configuration #1059

Closed
wants to merge 2 commits into from

Conversation

@bobheadxi
Copy link

bobheadxi commented Feb 8, 2019

This PR adds a new item to _variables.scss to allow configuration of main-h1-bg, for example:

// ...
$main-bg: #F3F7F9 !default;
$main-h1-bg: #c97a7e !default; // this is some kind of red
$aside-notice-bg: #8fbcd4 !default;
// ...

now you get:

image

and for logo margins, if you change it slightly:

$logo-margin-top: 16px !default; // margin above logo
$logo-margin-bot: 0px !default; // margin below logo

you now have a much nicer spacing on the navbar:

image

@bobheadxi bobheadxi changed the title Allow main-h1-bg configuration Allow main-h1-bg, logo-margin-top configuration Feb 8, 2019
@lord

This comment has been minimized.

Copy link
Member

lord commented Jun 1, 2019

Hi Robert! This is a cool addition, and while I'm sure many users would like to change this color, it's also the kind of change they can make directly without using variables? I'd rather not avoid adding too many variables for every possible styling change, since the end result of that is a variable for every CSS rule that we have. If you think this is a particular pain point, perhaps it could be documented in the wiki?

@lord lord closed this Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.