Bugfix: database and finish step errors #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ye that seems the correct approach for that notice. I will accept that. Thanks for the PR! Would be nice if you could do the same for the develop branch, if you don't mind :) #edit Nvm, I cherry-picked it to develop branch. |
slawkens
pushed a commit
that referenced
this pull request
Jan 1, 2024
danilopucci
added a commit
to danilopucci/myaac
that referenced
this pull request
Jan 2, 2024
slawkens
added a commit
that referenced
this pull request
Jan 30, 2024
This works for both, when output_buffering is enabled, and disabled
slawkens
added a commit
that referenced
this pull request
Jan 30, 2024
This works for both, when output_buffering is enabled, and disabled
danilopucci
pushed a commit
to danilopucci/myaac
that referenced
this pull request
May 27, 2024
…ing) This works for both, when output_buffering is enabled, and disabled
danilopucci
added a commit
to danilopucci/myaac
that referenced
this pull request
May 30, 2024
danilopucci
pushed a commit
to danilopucci/myaac
that referenced
this pull request
May 30, 2024
…ing) This works for both, when output_buffering is enabled, and disabled
danilopucci
pushed a commit
to danilopucci/myaac
that referenced
this pull request
May 30, 2024
…ing) This works for both, when output_buffering is enabled, and disabled
danilopucci
added a commit
to danilopucci/myaac
that referenced
this pull request
May 30, 2024
* Update common.php * Create SECURITY.md * Adding .env support (slawkens#1) * - adding composer * - adding .env support * Revert "Adding .env support (slawkens#1)" This reverts commit 79c570c. * Cleanup install folder (slawkens#7) * Adding .env support (slawkens#2) * - adding composer * - adding .env support * Improve DotEnv and fix e-mail settings (slawkens#3) * - revert changes on config.php, add config.local.php * - adding missing account e-mails settings * - adding check before flush buffer (slawkens#4) * - raw import myaac-gesior-shop-system-v5.0-beta.2 * Fresh install (slawkens#5) * - adding hidden ids * - hiding template * - removing katherine template * - moving game server files to a specific folder * Revert "Cleanup install folder (slawkens#7)" This reverts commit e8693bc. * Silently ignore if the hook does not exist * - adding check before flush buffer (slawkens#245) * Fix installation * Remove 31.php migration -> was for develop branch * Seems that this is better solution to the slawkens#245 (output buffering) This works for both, when output_buffering is enabled, and disabled * Fix broken installation I introduced in 0.8.15 * Revert "Fix installation" This reverts commit 9c318f9. * Release v0.8.16 * Fix date --------- Co-authored-by: slawkens <slawkens@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to run thw website locally (PHP 8) and I found that both database and finish steps were not running successfully:
When this happens on Database step and by hitting Next button at this step, the Finish step were skipped. It was assuming that it was already installed on
if(isset($config['installed']) && $config['installed'] && !isset($_SESSION['saved'])) {By reading ob_end_flush() docs, and by reading the Notice message, I found that it was throwning an error (which was unhandled at this time).
After applying these changes on Database step, the same error happened on Finish step
I simple added a check if the buffer has data to flush to avoid it. Maybe the best approach would be to catch the exception. But As it is part of install, which would be executed once, I think the if check is enough.
I could not force a valid buffer to see if the end_flush would fail in the same way that it was before