Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#181) make demos compile with glfw3 #182

Closed
wants to merge 1 commit into from
Closed

(#181) make demos compile with glfw3 #182

wants to merge 1 commit into from

Conversation

ldegen
Copy link

@ldegen ldegen commented May 24, 2019

This is basically the same as PR #151.

@ldegen ldegen mentioned this pull request May 24, 2019
@slembcke
Copy link
Owner

GLFW3 is all well and good. I use it in several of my other projects. The problem is that this will only work for Linux users. I've been meaning to replace GLFW with something that builds out of the box on Mac and Windows too. Windows devs in particular are very... vocal... when things don't just work and I already have to deal with the disaster that is MSVC support. In the past I supported them by shipping GLFW binaries, and that's not really sustainable.

Anyway, I think there are probably 3 branches floating around at this point for GLFW3 support including one I made that replaced the GL2 renderer with a GL3.3 one. A couple weeks ago I started a Sokol app version, and I'm pretty happy with this since it's pretty trivial to distribute as source. I just have to finish rewriting the renderer, and I'm hoping to do that this week or next.

@slembcke slembcke closed this May 28, 2019
@slembcke
Copy link
Owner

slembcke commented Jun 4, 2019

The demo app is mostly rewritten to run on top of sokol_app and sokol_gfx now. Need to double check that it compiles on Mac and Windows now, but I wouldn't turn down help testing on Linux. ;)

https://github.com/slembcke/Chipmunk2D/tree/sokol

@aismann
Copy link
Contributor

aismann commented Jun 5, 2019

@slembcke
I have built a VS2019 version of your latest sokol branch.
After some small changes the sokol demo (debug and realease) works great on Windows.

@ldegen
Copy link
Author

ldegen commented Jun 5, 2019

@slembcke just pulled your changes. I'm happy to report that the sokol branch compiles + runs out of the box on my linux box (Debian sid). I will do a more thorough test this evening.

@slembcke
Copy link
Owner

slembcke commented Jun 5, 2019

@aismann That's good to know. I used a bunch of C99 features that I assumed would need to be removed. I might bump up the minimum supported MSVC version to get better C99 compat... Will see I guess.

@ldegen
Copy link
Author

ldegen commented Jun 6, 2019

@slembcke FYI: did a clean compile last night (both debug and release), toyed around with all of the demos. No issues, as far as I could tell. (Debian sid/X86_64)

@slembcke
Copy link
Owner

slembcke commented Jun 7, 2019

Implemented for Mac/Win as well, and merged to master! No longer reliant on a dead version of GLFW or an ancient GL2 renderer.

I'll stop poking this dead pull request now. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants