-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for circleCI and initial GitHub Actions #2778
base: develop
Are you sure you want to change the base?
Conversation
This is pretty neat. I'm not using circleci, but I guess you are? |
Going to close and reopen force our checks to run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you separate this into two PRs, one for .circleci and one that modifies our existing github actions to add the Java testing?
- name: Fix Line Endings | ||
run: | | ||
sudo apt update && | ||
sudo apt -y install dos2unix && | ||
find . \( -name "*.m4" -o -name "*.ac" -o -name "*.am" \) | xargs dos2unix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of this?
- name: Run The Sleuth Kit tests | ||
run: ant -f ./bindings/java clean dist test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make more sense to add this to our existing github actions (which didn't exist when you submitted this).
Add support for Circle CI.
Adds a github action...