Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for circleCI and initial GitHub Actions #2778

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

gdicristofaro
Copy link
Contributor

@gdicristofaro gdicristofaro commented Nov 3, 2022

Add support for Circle CI.
Adds a github action...

@gdicristofaro gdicristofaro marked this pull request as draft November 3, 2022 18:35
@simsong
Copy link
Member

simsong commented Sep 11, 2024

This is pretty neat. I'm not using circleci, but I guess you are?

@simsong
Copy link
Member

simsong commented Sep 11, 2024

Going to close and reopen force our checks to run.

@simsong simsong closed this Sep 11, 2024
@simsong simsong reopened this Sep 11, 2024
Copy link
Member

@simsong simsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you separate this into two PRs, one for .circleci and one that modifies our existing github actions to add the Java testing?

Comment on lines +31 to +35
- name: Fix Line Endings
run: |
sudo apt update &&
sudo apt -y install dos2unix &&
find . \( -name "*.m4" -o -name "*.ac" -o -name "*.am" \) | xargs dos2unix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this?

Comment on lines +44 to +45
- name: Run The Sleuth Kit tests
run: ant -f ./bindings/java clean dist test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make more sense to add this to our existing github actions (which didn't exist when you submitted this).

@simsong simsong changed the title 8445 pr tests Add support for circleCI and initial GitHub Actions Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants