PHP/UselessParentheses: prevent error for parse error

``` An error occurred during processing; checking has been aborted. The error message was: Undefined array key "parenthesis_closer" in path\to\SlevomatCodingStandard\Sniffs\PHP\UselessParenthesesSniff.php on line 178```
slevomat · Oct 5, 2023 · 2d45e24 · 2d45e24
1 parent f150966
commit 2d45e24
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 2 deletions.
diff --git a/SlevomatCodingStandard/Sniffs/PHP/UselessParenthesesSniff.php b/SlevomatCodingStandard/Sniffs/PHP/UselessParenthesesSniff.php
@@ -122,6 +122,10 @@ public function process(File $phpcsFile, $parenthesisOpenerPointer): void
 			return;
 		}
 
+		if (!array_key_exists('parenthesis_closer', $tokens[$parenthesisOpenerPointer])) {
+			return;
+		}
+
 		/** @var int $pointerBeforeParenthesisOpener */
 		$pointerBeforeParenthesisOpener = TokenHelper::findPreviousEffective($phpcsFile, $parenthesisOpenerPointer - 1);
 		if (in_array($tokens[$pointerBeforeParenthesisOpener]['code'], array_merge(
@@ -386,7 +390,7 @@ private function checkParenthesesAroundVariableOrFunctionCall(File $phpcsFile, i
 			} while (true);
 		} else {
 			$nextPointer = TokenHelper::findNext($phpcsFile, T_OPEN_PARENTHESIS, $notBooleanNotOperatorPointer + 1);
-			if ($nextPointer === null) {
+			if ($nextPointer === null || !isset($tokens[$nextPointer]['parenthesis_closer'])) {
 				return;
 			}
 

diff --git a/tests/Sniffs/PHP/UselessParenthesesSniffTest.php b/tests/Sniffs/PHP/UselessParenthesesSniffTest.php
@@ -34,4 +34,10 @@ public function testNoErrorsWithIgnoredComplexTernaryConditions(): void
 		self::assertNoSniffErrorInFile($report);
 	}
 
+	public function testNoErrorsLiveCoding(): void
+	{
+		$report = self::checkFile(__DIR__ . '/data/uselessParenthesesLiveCoding.php');
+		self::assertNoSniffErrorInFile($report);
+	}
+
 }
diff --git a/tests/Sniffs/PHP/data/uselessParenthesesLiveCoding.php b/tests/Sniffs/PHP/data/uselessParenthesesLiveCoding.php
@@ -0,0 +1,5 @@
+<?php // lint >= 99.0
+
+// Live coding/parse error.
+// This must be the last test in the file.
+if ($a = 1
diff --git a/tests/Sniffs/PHP/data/uselessParenthesesNoErrors.php b/tests/Sniffs/PHP/data/uselessParenthesesNoErrors.php
@@ -177,4 +177,3 @@ function ($value) {
 return true
 	? 100
 	: (int) ((100 <=> 50) * 100);
-