Updated to PHP CodeSniffer 3

[kukulich]

No description provided.

[TomasVotruba]

Awesome job! I'm amazed you think about future compatibility in such level.

[TomasVotruba]

Let me know if you need any help.

[TomasVotruba]

Showcase PR with CodeSniffer upgrade 2.x => 3.x: https://github.com/hostnet/phpcs-tool/pull/16/files

[TomasVotruba]

Hey, I just wanted to ask. I depend with few packages of mine on this, using awesome helpers in it + CodeSniffer 3.0. Among 2 from Symplify, also https://github.com/object-calisthenics/phpcs-calisthenics-rules

This is the last unupdated-package to get to stable release, that I'd like to sync with Symfony 3.3 release (in ~10 days). I'd like to know, when do you plan to merge and release CodeSniffer 3.0 version.

So I could decide, if I should wait or if I should copy-paste those helpers for now and update them to CodeSniffer 3.0.

Thank you

[VasekPurchart]

CodeSniffer in versions 2.9.0 and 3.0 is unusable for code on PHP 7.1 using nullable types, see squizlabs/PHP_CodeSniffer#1442, so there is not much sense in supporting it currently unfortunately.

[TomasVotruba]

@VasekPurchart Thanks for linking this. I hope this will be solved ASAP.

[il-m-yamagishi]

Hey, I also need this PR to be merged.

But my custom sniff repository currently depends on "squizlabs/php_codesniffer": "~3.0.0" .

So I cannot require this branch(also future merged branch).

I suggest the dependency version ~3.0.0 or ^3.0 will be better than dev-master .

(I say Sorry when you supposed to change this version when PHPCS3.0.1 released.)

Thanks.

[kukulich]

Yes, I'll use ^3.0.1 :) I just want to test that there is no other bug in PHPCS.

[mavimo]

issues is fixed with phpcs 3.0.1, I think whould possibile use this patch version as minimum requirement.

[TomasVotruba]

@kukulich 👏 👏 👏

@mavimo Thanks for the news!