Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PropertySpacingSniff and ConstantSpacingSniff #832

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Add PropertySpacingSniff and ConstantSpacingSniff #832

merged 1 commit into from
Jan 16, 2020

Conversation

grongor
Copy link
Contributor

@grongor grongor commented Jan 15, 2020

Part of #701 series.

🔧 TODO: add readme if sniff is accepted

@kukulich
Copy link
Contributor

I think it would be better to split this sniff to PropertySpacingSniff and ConstantSpacingSniff. And remove "Property" string from all options.

@grongor
Copy link
Contributor Author

grongor commented Jan 15, 2020

Done

@kukulich kukulich added this to the 6.1.0 milestone Jan 15, 2020
@kukulich
Copy link
Contributor

LGTM.

@grongor grongor changed the title Add PropertyAndConstantSpacingSniff Add PropertySpacingSniff and ConstantSpacingSniff Jan 16, 2020
@kukulich kukulich merged commit ee7a8c6 into slevomat:master Jan 16, 2020
@jrfnl jrfnl mentioned this pull request Jan 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kukulich kukulich kukulich approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grongor @kukulich