Fix RequireSingleLineMethodSignature for semicolons #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kukulich
requested changes
Jan 23, 2020
SlevomatCodingStandard/Sniffs/Classes/RequireSingleLineMethodSignatureSniff.php
Outdated
Show resolved
Hide resolved
|
I'm not sure why I changed it. I tested it on whole Slevomat and there was some bugs I've fixed etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why would you @kukulich change the test when it was working fine before ... anyway, I reverted your change and added a fix.
Without this, the phpcs was jumping between LineLengthSniff error when on single line and with error here when on multiple lines...