Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation into user directory #334

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

fdcds
Copy link
Contributor

@fdcds fdcds commented Jul 30, 2019

This allows pip install --user SafeEyes or python setup.py install --user to work.

This allows `pip install --user SafeEyes` or `python setup.py install --user` to work.
@slgobinath
Copy link
Owner

@fdcds thank you for your contribution.

@slgobinath slgobinath merged commit 1e37866 into slgobinath:master Jul 30, 2019
@TPXP
Copy link

TPXP commented Aug 23, 2020

This causes an issue when packaging SafeEyes: it will install stuff to the home directory of the user who built the package.
I implemented a workaround on the AUR package for safeeyes-git, but it's probably not the best idea. Perhaps try catching the --rootdir argument, or add a --system option?

See my comment on the AUR (and the reports below): https//aur.archlinux.org/packages/safeeyes-git/#comment-762203
My workaround: https://aur.archlinux.org/cgit/aur.git/commit/PKGBUILD?h=safeeyes-git&id=5477aa5e6c17393f56506ae39bd4dcd925288745

@slgobinath
Copy link
Owner

@TPXP I'm terribly sorry for not replying you. I missed your comment and just noticed it while checking your AUR package. First of all thank you very much for maintaining the safeeyes-git AUR.

For this particular issue, if you have any solution, I'd appreciate a PR. I'm bit busy with some personal commitments. I will get back to this when I get some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants