New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.2.1 Retraction Length 0 disables Firmware Retraction #2359

Closed
mitchese opened this Issue Nov 16, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@mitchese

Choosing the option "Use firmware retraction" in Printer/General only generates G10/G11 if the option "Retraction Length" in Printer/Extruder x is nonzero (not disabled).

In the 1.2.1 Version, selecting "Use firmware retraction" in Printer/General disables the box to set the retraction length (in my opinion, correct behaviour). If this field was previously set to zero, it is now locked at zero and not possible to change until firmware retraction option is unselected.

Steps to re-create:

  1. Set Retraction Length to zero
  2. Set to use firmware retraction
  3. Generate G-Code -- no G10/G11 anywhere in the output
  4. Try to change Retraction Length to 1 -- input is disabled
  5. Disable firmware retraction
  6. Change retraction length to a nonzero value (1)
  7. Re-enable firmware retraction
  8. Generate G-code: now correct with G10/G11

alexrj added a commit that referenced this issue Nov 23, 2014

Fixed regression causing retraction to be skipped when Retract Length…
… was 0 but Use Firmware Retraction was enabled. Includes regression test. #2359
@alexrj

This comment has been minimized.

Show comment
Hide comment
@alexrj

alexrj Nov 23, 2014

Member

Thank you, I fixed this and added a regression test.

Member

alexrj commented Nov 23, 2014

Thank you, I fixed this and added a regression test.

@alexrj alexrj closed this Nov 23, 2014

@alexrj alexrj added this to the 1.2.2 milestone Nov 23, 2014

@alexrj alexrj added the Fixed label Nov 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment