Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for Postgres citext #1848
Conversation
stewSquared
added some commits
Feb 5, 2018
stewSquared
reviewed
Feb 16, 2018
| * Should be based on the value of dbType in the future. */ | ||
| def varying: Boolean = { | ||
| import java.sql.Types._ | ||
| Seq(NVARCHAR, VARCHAR, LONGVARCHAR, LONGNVARCHAR) contains meta.sqlType |
This comment has been minimized.
This comment has been minimized.
stewSquared
Feb 16, 2018
Author
Contributor
Note that postgres jdbc driver maps text to VARCHAR, but citext to OTHER, which is why text type doesn't need special treatment in def varying below.
stewSquared
reviewed
Feb 16, 2018
project/build.properties
Outdated
| @@ -1 +1 @@ | |||
| sbt.version=0.13.13 | |||
This comment has been minimized.
This comment has been minimized.
stewSquared
Feb 16, 2018
Author
Contributor
I needed to upgrade sbt version for this fix: sbt/sbt#3265
There is a platform-specific issue that comes up for some people with newer versions of ncurses: sbt/sbt#3240
Let me know if this should be part of a separate PR.
stewSquared
referenced this pull request
Feb 16, 2018
Merged
Make ModelBuilders easier to customize via inner classes #1849
hvesalai
added this to the
Next feature release milestone
Feb 28, 2018
hvesalai
modified the milestones:
Future feature release,
3.3
Mar 26, 2018
This comment has been minimized.
This comment has been minimized.
|
@stewSquared could you rebase this to current master. |
This comment has been minimized.
This comment has been minimized.
|
@hvesalai Sorry for the late reply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
stewSquared commentedFeb 16, 2018
•
edited
Resolves #1847
Note that this PR doesn't handle handling of default values. See #1842