New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Postgres citext #1848

Merged
merged 4 commits into from May 19, 2018

Conversation

Projects
None yet
2 participants
@stewSquared
Copy link
Contributor

stewSquared commented Feb 16, 2018

Resolves #1847
Note that this PR doesn't handle handling of default values. See #1842

* Should be based on the value of dbType in the future. */
def varying: Boolean = {
import java.sql.Types._
Seq(NVARCHAR, VARCHAR, LONGVARCHAR, LONGNVARCHAR) contains meta.sqlType

This comment has been minimized.

@stewSquared

stewSquared Feb 16, 2018

Author Contributor

Note that postgres jdbc driver maps text to VARCHAR, but citext to OTHER, which is why text type doesn't need special treatment in def varying below.

@@ -1 +1 @@
sbt.version=0.13.13

This comment has been minimized.

@stewSquared

stewSquared Feb 16, 2018

Author Contributor

I needed to upgrade sbt version for this fix: sbt/sbt#3265

There is a platform-specific issue that comes up for some people with newer versions of ncurses: sbt/sbt#3240

Let me know if this should be part of a separate PR.

@hvesalai hvesalai added this to the Next feature release milestone Feb 28, 2018

@hvesalai hvesalai modified the milestones: Future feature release, 3.3 Mar 26, 2018

@hvesalai

This comment has been minimized.

Copy link
Member

hvesalai commented Mar 26, 2018

@stewSquared could you rebase this to current master.

@stewSquared

This comment has been minimized.

Copy link
Contributor Author

stewSquared commented Apr 11, 2018

@hvesalai Sorry for the late reply.
I'll spruce up my pulls and issues early next week.

@hvesalai hvesalai merged commit fa78a99 into slick:master May 19, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment