Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Postgres citext #1848

Merged
merged 4 commits into from May 19, 2018
Merged

Conversation

@stewSquared
Copy link
Contributor

@stewSquared stewSquared commented Feb 16, 2018

Resolves #1847
Note that this PR doesn't handle handling of default values. See #1842

* Should be based on the value of dbType in the future. */
def varying: Boolean = {
import java.sql.Types._
Seq(NVARCHAR, VARCHAR, LONGVARCHAR, LONGNVARCHAR) contains meta.sqlType
Copy link
Contributor Author

@stewSquared stewSquared Feb 16, 2018

Note that postgres jdbc driver maps text to VARCHAR, but citext to OTHER, which is why text type doesn't need special treatment in def varying below.

@@ -1 +1 @@
sbt.version=0.13.13
Copy link
Contributor Author

@stewSquared stewSquared Feb 16, 2018

I needed to upgrade sbt version for this fix: sbt/sbt#3265

There is a platform-specific issue that comes up for some people with newer versions of ncurses: sbt/sbt#3240

Let me know if this should be part of a separate PR.

@hvesalai hvesalai added this to the Next feature release milestone Feb 28, 2018
@hvesalai hvesalai removed this from the Future feature release milestone Mar 26, 2018
@hvesalai hvesalai added this to the 3.3 milestone Mar 26, 2018
@hvesalai
Copy link
Member

@hvesalai hvesalai commented Mar 26, 2018

@stewSquared could you rebase this to current master.

@stewSquared
Copy link
Contributor Author

@stewSquared stewSquared commented Apr 11, 2018

@hvesalai Sorry for the late reply.
I'll spruce up my pulls and issues early next week.

@hvesalai hvesalai merged commit fa78a99 into slick:master May 19, 2018
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants