Add support for Postgres citext #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stewSquared
commented
Feb 16, 2018
| * Should be based on the value of dbType in the future. */ | ||
| def varying: Boolean = { | ||
| import java.sql.Types._ | ||
| Seq(NVARCHAR, VARCHAR, LONGVARCHAR, LONGNVARCHAR) contains meta.sqlType |
There was a problem hiding this comment.
Note that postgres jdbc driver maps text to VARCHAR, but citext to OTHER, which is why text type doesn't need special treatment in def varying below.
stewSquared
commented
Feb 16, 2018
project/build.properties
Outdated
| @@ -1 +1 @@ | |||
| sbt.version=0.13.13 | |||
There was a problem hiding this comment.
I needed to upgrade sbt version for this fix: sbt/sbt#3265
There is a platform-specific issue that comes up for some people with newer versions of ncurses: sbt/sbt#3240
Let me know if this should be part of a separate PR.
|
@stewSquared could you rebase this to current master. |
|
@hvesalai Sorry for the late reply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1847
Note that this PR doesn't handle handling of default values. See #1842