Update HikariCP to 5.0.0

[scala-steward]

Updates com.zaxxer:HikariCP from 4.0.3 to 5.0.0.

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.zaxxer", artifactId = "HikariCP" } ]

labels: library-update, semver-major

[nafg]

I don't see an announcement, but it looks like version 5 is about dropping java 8 support, so no wonder it fails our CI for java 8.

[xuwei-k]

brettwooldridge/HikariCP@1991355

[nafg]

@SethTisue is there any kind of timeline (or version) when it would be acceptable to drop Java 8 support? There's no obligation to upgrade our HikariCP version, but if yes this PR could be assigned a milestone or something instead of being closed.

[nafg]

Well I guess it could either be assigned to Future feature release or to something more definite...

[SethTisue]

I wouldn't object to dropping Java 8 support if the HikariCP upgrade is considered highly desirable. But if it's more just that we're mechanically bumping versions and nobody is actually eager for the upgrade, then I'd suggest deferring it a while longer.

[nafg]

I don't know that it's desirable. In fact AFAICT/IIRC the only change was dropping Java 8. Maybe something more interesting is in the pipeline though.

Do you think I should leave it open and assign it to "Future feature release" milestone, or close it?

[SethTisue]

I think it's fine to close it. Anyone with an interest in HikariCP will still readily be able to find it, even in its closed state.

[nafg]

Seems like the hsqldb driver has dropped Java 8 support to (by CI results)

[scala-steward]

Superseded by #2359.