fix: conditional auto scroll for notes

slidevjs · Feb 26, 2024 · 0b2450c · 0b2450c
1 parent c5a5fdd
commit 0b2450c
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/packages/client/internals/NoteDisplay.vue b/packages/client/internals/NoteDisplay.vue
@@ -9,6 +9,7 @@ const props = defineProps<{
   note?: string
   placeholder?: string
   clicksContext?: ClicksContext
+  autoScroll?: boolean
 }>()
 
 defineEmits(['click'])
@@ -97,7 +98,7 @@ function highlightNote() {
       e.stopImmediatePropagation()
     })
 
-    if (clicks === current)
+    if (props.autoScroll && clicks === current)
       marker.scrollIntoView({ block: 'center', behavior: 'smooth' })
   }
 }

diff --git a/packages/client/internals/NoteEditor.vue b/packages/client/internals/NoteEditor.vue
@@ -106,6 +106,7 @@ watch(
     :note="note || placeholder"
     :note-html="info?.noteHTML"
     :clicks-context="clicksContext"
+    :auto-scroll="!autoHeight"
   />
   <textarea
     v-else

diff --git a/packages/client/pages/notes.vue b/packages/client/pages/notes.vue
@@ -52,6 +52,7 @@ function decreaseFontSize() {
         :note-html="currentRoute?.meta?.slide?.noteHTML"
         :placeholder="`No notes for Slide ${pageNo}.`"
         :clicks-context="currentRoute?.meta?.__clicksContext"
+        :auto-scroll="true"
       />
     </div>
     <div class="flex-none border-t border-main">

diff --git a/packages/client/pages/presenter/print.vue b/packages/client/pages/presenter/print.vue
@@ -56,7 +56,10 @@ const slidesWithNote = computed(() => rawRoutes
               <div class="flex-auto" />
             </div>
           </h2>
-          <NoteDisplay :note-html="slide!.noteHTML" class="max-w-full" />
+          <NoteDisplay
+            :note-html="slide!.noteHTML"
+            class="max-w-full"
+          />
         </div>
         <hr v-if="index < slidesWithNote.length - 1" class="border-main mb-8">
       </div>