Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeMirror editor deletes all other pages of a markdown file when multiple entries are used #1111

Closed
ChewbaccaCookie opened this issue Sep 10, 2023 · 1 comment · Fixed by #1299
Closed

CodeMirror editor deletes all other pages of a markdown file when multiple entries are used #1111

ChewbaccaCookie opened this issue Sep 10, 2023 · 1 comment · Fixed by #1299
Labels
bug Something isn't working

Comments

@ChewbaccaCookie
Copy link

Describe the bug
If a user uses the CodeMirror editor for editing, and this slide is imported somewhere else, then all other slides, except the currently modified one, are deleted.

Before:
image

Editing:
image

After:
image

--> Page 1 was deleted.

To Reproduce
Steps to reproduce the behavior:

  1. Go to this example: Stackblitz
  2. Go to page 2 or 3
  3. Click on the "Edit file" icon in the bottom left navigation
  4. Edit the content of the page

Desktop (please complete the following information):

  • OS: All
  • Browser: All
  • Slidev version: Latest
@KermanX
Copy link
Member

KermanX commented Feb 7, 2024

Cannot reproduce in v0.47.4

@KermanX KermanX added needs reproduction bug Something isn't working and removed needs reproduction labels Feb 11, 2024
@KermanX KermanX mentioned this issue Feb 16, 2024
Closed
KermanX added a commit to KermanX/slidev that referenced this issue Feb 16, 2024
@KermanX
fix: save external slide (slidevjs#1111)
89d5cad
@KermanX KermanX mentioned this issue Feb 16, 2024
Merged
antfu pushed a commit that referenced this issue Feb 16, 2024
@KermanX
fix: save external slide (#1111) (#1299)
f395b29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: save external slide (#1111) KermanX/slidev
2 participants
@ChewbaccaCookie @KermanX