Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to control the quality of the png export #1263

Closed
juanrgon opened this issue Feb 1, 2024 · 3 comments
Closed

Ability to control the quality of the png export #1263

juanrgon opened this issue Feb 1, 2024 · 3 comments
Labels
enhancement New feature or request pr welcome

Comments

@juanrgon
Copy link

juanrgon commented Feb 1, 2024

Is your feature request related to a problem? Please describe.

Frustrated that I can't control the quality of the pngs that are exported when running:

npx slidev export --format png

Describe the solution you'd like

I would like to be able to control the quality via a feature flag of some sort

@juanrgon juanrgon added the enhancement New feature or request label Feb 1, 2024
@antfu
Copy link
Member

antfu commented Feb 1, 2024

I think we could have an option to change the resolutions on exporting. PR welcome if someone wants to work on it

@KermanX
Copy link
Member

KermanX commented Feb 4, 2024

According to https://playwright.dev/docs/api/class-page#page-screenshot-option-quality, exporting in PNG format does not support the quality option (JPEG is OK):

image

Perhaps what @juanrgon needs is a feature to zoom in to make the exported image clearer.

update: See #1274

@KermanX
Copy link
Member

KermanX commented Feb 11, 2024

I think 1eaf92a (PR #1274) is what this issue requests. Close this for now.

@KermanX KermanX closed this as completed Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pr welcome
Projects
None yet
Development

No branches or pull requests

3 participants