Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --bind option #1302

Merged
merged 1 commit into from Feb 19, 2024
Merged

feat: add --bind option #1302

merged 1 commit into from Feb 19, 2024

Conversation

KermanX
Copy link
Member

@KermanX KermanX commented Feb 16, 2024

resolves #1180.

This PR adds a --bind CLI option to bind a specific address in remote mode.

The reason why this option isn't named as --host is that, --host without a string arg in Vite works like --remote in Slidev. If this option is named --host, it will make the user confused.

@KermanX KermanX marked this pull request as draft February 16, 2024 11:57
@KermanX KermanX marked this pull request as ready for review February 16, 2024 11:58
@antfu antfu merged commit d23d5f5 into slidevjs:main Feb 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to bind a specific address
2 participants