Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade mermaid #211

Closed
ameinhardt opened this issue Jun 1, 2021 · 3 comments
Closed

upgrade mermaid #211

ameinhardt opened this issue Jun 1, 2021 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed pr welcome

Comments

@ameinhardt
Copy link
Contributor

Is your feature request related to a problem? Please describe.
gantt.sectionFontSize doesn't work for me in mermaid = 8.5.0

Describe the solution you'd like
Allow newer minor version of mermaid, e.g. ^8.10.1

Describe alternatives you've considered
using a combination of setup/mermaid.ts and !important style rules

@ameinhardt ameinhardt added the enhancement New feature or request label Jun 1, 2021
@antfu
Copy link
Member

antfu commented Jun 2, 2021

Currently we are having some issue with the integration of mermaid greater than v8.5. If you want, maybe you can give it a try and I am more than happy to review the PR. Thanks

@antfu antfu added help wanted Extra attention is needed pr welcome labels Jun 2, 2021
@christian-nils
Copy link
Contributor

But you cannot use gantt.sectionFontSize because the types for mermaid are outdated, or?

Can't you just use this in your stylesheet instead?

.mermaid .sectionTitle > tspan {
  @apply text-sm;
}

@ameinhardt
Copy link
Contributor Author

the mermaid css is scoped and thus its theme takes precedence. It's possible to use theme: 'null' in mermaid config and link a custom mermaid style in slidev theme, though.

antfu added a commit that referenced this issue Sep 13, 2021
@antfu antfu closed this as completed in 5000419 Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed pr welcome
Projects
None yet
Development

No branches or pull requests

3 participants