fix: monaco editor types resolution #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KermanX
commented
Feb 27, 2024
| @@ -43,19 +43,20 @@ export function createMonacoTypesLoader({ userRoot }: ResolvedSlidevOptions): Pl | |||
| ].join('\n') | |||
| } | |||
|
|
|||
| const matchLoad = id.match(/^\/\@slidev-monaco-types\/load(\/.*?)&name=(.*)$/) | |||
| const matchLoad = id.match(/^\/\@slidev-monaco-types\/load\/(.*?)&name=(.*)$/) | |||
There was a problem hiding this comment.
Not very sure about this change. (Reverting a85ac6a)
There was a problem hiding this comment.
Some resolution add leading slash some are not, you will see paths like:
/@slidev-monaco-types/load//Users/xx... and
/@slidev-monaco-types/load/Users/xx...
We should probably unify them on generation. We just need to make sure the root passed to fg is absolute.
(and this might have some issues on Windows? 👀)
There was a problem hiding this comment.
Yes. This is broken on Windows.
There was a problem hiding this comment.
I've changed the URL format to
/@slidev-monaco-types/resolve?pkg=...&importer=.../@slidev-monaco-types/load?root=...&name=...
Also, raw imports are now like ...?monaco-types&raw, so that manualChunk can work correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes:
omit duplicate dependencies
declaration files searching